search

yasoob / nrc-exporter

Download your runs data from Nike Run Club and convert it to GPX format that can be imported in other running apps.
https://yasoob.me/posts/reverse-engineering-nike-run-club-using-frida-android/
MIT License
120 stars 14 forks source link

Issue regarding activities list #8

Closed snmac13 closed 4 years ago

snmac13 commented 4 years ago

I just want to say thanks for creating this. Having the NRC data will be so helpful. I used the 'arc-exporter -t "token"' command and ran into this issue. Any idea what is going wrong here? All help will be much appreciated. Thanks!

[+] Starting NRC Exporter [+] 🏃‍♀️ Getting activities list [+] 📃 opening page 1 of activities [+] 📃 opening page 2 of activities [+] 📃 opening page 3 of activities [+] 📃 opening page 4 of activities [+] 📃 opening page 5 of activities [+] 📃 opening page 6 of activities [+] 📃 opening page 7 of activities [+] 📃 opening page 8 of activities [+] 📃 opening page 9 of activities Traceback (most recent call last): File "/Users/me/.pyenv/versions/3.8.3/bin/nrc-exporter", line 8, in sys.exit(main()) File "/Users/me/.pyenv/versions/3.8.3/lib/python3.8/site-packages/nrc_exporter.py", line 611, in main activity_ids = get_activities_list(options) File "/Users/me/.pyenv/versions/3.8.3/lib/python3.8/site-packages/nrc_exporter.py", line 306, in get_activities_list debug(f"Entry type: {activity['tags'].get('com.nike.running.runtype', '')}") KeyError: 'tags'

yasoob commented 4 years ago

The JSON result coming from Nike is causing this problem. I will need to take a look at the output you are receiving from Nike to fix this. Let me know if you know Python and can run a customized Python script with more debugging output if I share it with you. If you can't do that, we can find a different way to debug this.

snmac13 commented 4 years ago

yasoob,

Thanks for the response. I can run the script if you would like.Thanks

yihong0618 commented 4 years ago

@yasoob it seems that some synchronized data has no label of tag ?

Can we use:

activity.get("tag", {}).get('com.nike.running.runtype', '')

instead

yasoob commented 4 years ago

@yihong0618 that is what I thought so as well but didn't have a way to reproduce it. I was gonna suggest @snmac13 to send me the activity file but if you believe that this is definitely the issue, your suggestion seems like a plausible fix. Would you be willing to open a PR?

yihong0618 commented 4 years ago

@yihong0618 that is what I thought so as well but didn't have a way to reproduce it. I was gonna suggest @snmac13 to send me the activity file but if you believe that this is definitely the issue, your suggestion seems like a plausible fix. Would you be willing to open a PR?

Yes, I think I can open a PR later today.

yasoob commented 4 years ago

@snmac13 I will make a new PyPI release soon but in the meantime you can just install nrc-exporter from this repo and hopefully the issue should be resolved :)

snmac13 commented 4 years ago

Will get to this momentarily. Sorry for the delay.

On Fri, Jul 24, 2020 at 4:15 PM M.Yasoob Ullah Khalid ☺ < notifications@github.com> wrote:

@snmac13 https://github.com/snmac13 I will make a new pip release soon but in the meantime you can just install nrc-exporter from this repo and hopefully the issue should be resolved :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yasoob/nrc-exporter/issues/8#issuecomment-663769522, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOCBRGTRYWJKIP72SC55K43R5IIZ7ANCNFSM4PFBOGPQ .