search

yasserqureshi1 / Sneaker-Monitors

A collection of web monitors that notify of restocks or updates on sneaker related sites through Discord Webhook. This includes Shopify, Nike SNKRS (supports 42 countries), Supreme and now Footsite monitors!
GNU General Public License v3.0
462 stars 126 forks source link

showing all products not just new ones? #32

Closed DarylRob closed 3 years ago

DarylRob commented 3 years ago

I've only run the shopify one so far, but it looks like its just parsing through the info and sending every product on the site not just the updates? Is that right? Wouldn't you need to do some sort of compare to see what's new?

yasserqureshi1 commented 3 years ago

I've only run the shopify one so far, but it looks like its just parsing through the info and sending every product on the site not just the updates? Is that right? Wouldn't you need to do some sort of compare to see what's new?

Hi. It is supposed to compare and only send updates. I'll have a look into this. Thanks for letting me know

DarylRob commented 3 years ago

Nice one mate, just run the SNKRS one as well and it seems to be doing the same. I'm trying to have a look myself but I'm new to python/programming so might take me a bit longer.

yasserqureshi1 commented 3 years ago

I have recently fixed the Shopify monitor. Realised there were a few bugs I missed out! This will be pushed to GitHub shortly. I'll look into SNKRS now.

yasserqureshi1 commented 3 years ago

I've checked out the SNKRS code, tested it and updated it. If you have any other issues let me know and I'll try sort them out as quickly as possible

DarylRob commented 3 years ago

Thank you mate, are both updated on github

-------- Original message -------- From: Yasser Qureshi notifications@github.com Date: 01/01/2021 01:30 (GMT+00:00) To: yasserqureshi1/Sneaker-Monitors Sneaker-Monitors@noreply.github.com Cc: DarylRob darylrobins@live.com, Author author@noreply.github.com Subject: Re: [yasserqureshi1/Sneaker-Monitors] showing all products not just new ones? (#32)

I've checked out the SNKRS code, tested it and updated it. If you have any other issues let me know and I'll try sort them out as quickly as possible

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yasserqureshi1/Sneaker-Monitors/issues/32#issuecomment-753238088, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR4L6IFDK7R63VZ4ZYEZTJ3SXUQTVANCNFSM4VOONTFA.

yasserqureshi1 commented 3 years ago

Thank you mate, are both updated on github

-------- Original message -------- From: Yasser Qureshi notifications@github.com Date: 01/01/2021 01:30 (GMT+00:00) To: yasserqureshi1/Sneaker-Monitors Sneaker-Monitors@noreply.github.com Cc: DarylRob darylrobins@live.com, Author author@noreply.github.com Subject: Re: [yasserqureshi1/Sneaker-Monitors] showing all products not just new ones? (#32)

I've checked out the SNKRS code, tested it and updated it. If you have any other issues let me know and I'll try sort them out as quickly as possible

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yasserqureshi1/Sneaker-Monitors/issues/32#issuecomment-753238088, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR4L6IFDK7R63VZ4ZYEZTJ3SXUQTVANCNFSM4VOONTFA.

Yep. Both should be working now

DarylRob commented 3 years ago

Top man. Any chance you can describe what the issue was? Just help my learn process..

Sent from my Galaxy

-------- Original message -------- From: Yasser Qureshi notifications@github.com Date: 01/01/2021 10:18 (GMT+00:00) To: yasserqureshi1/Sneaker-Monitors Sneaker-Monitors@noreply.github.com Cc: DarylRob darylrobins@live.com, Author author@noreply.github.com Subject: Re: [yasserqureshi1/Sneaker-Monitors] showing all products not just new ones? (#32)

Thank you mate, are both updated on github

-------- Original message -------- From: Yasser Qureshi notifications@github.commailto:notifications@github.com Date: 01/01/2021 01:30 (GMT+00:00) To: yasserqureshi1/Sneaker-Monitors Sneaker-Monitors@noreply.github.commailto:Sneaker-Monitors@noreply.github.com Cc: DarylRob darylrobins@live.commailto:darylrobins@live.com, Author author@noreply.github.commailto:author@noreply.github.com Subject: Re: [yasserqureshi1/Sneaker-Monitors] showing all products not just new ones? (#32https://github.com/yasserqureshi1/Sneaker-Monitors/issues/32)

I've checked out the SNKRS code, tested it and updated it. If you have any other issues let me know and I'll try sort them out as quickly as possible

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub#32 (comment)https://github.com/yasserqureshi1/Sneaker-Monitors/issues/32#issuecomment-753238088, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR4L6IFDK7R63VZ4ZYEZTJ3SXUQTVANCNFSM4VOONTFA.

Yep. Both should be working now

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yasserqureshi1/Sneaker-Monitors/issues/32#issuecomment-753297141, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR4L6IBUAABRBFY4TC2BCBLSXWOPNANCNFSM4VOONTFA.