yassinebridi / serpl

A simple terminal UI for search and replace, ala VS Code.
MIT License
567 stars 4 forks source link

Crash when ripgrep is not installed #28

Closed skeet70 closed 3 months ago

skeet70 commented 4 months ago

I start the program, type anything, and it crashes immediately every time. Installed with cargo.

name = "serpl"
operating_system = "NixOS 24.11.0 [64-bit]"
crate_version = "0.3.1"
explanation = """
Panic occurred in file '/home/x/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serpl-0.3.1/src/redux/thunk/process_search.rs' at line 138
"""
cause = 'Failed to execute ripgrep: Os { code: 2, kind: NotFound, message: "No such file or directory" }'
method = "Panic"
backtrace = """

   0: 0x560e44edc143 - core::result::unwrap_failed::h1356562ef8bc898c
   1: 0x560e44f44fed - <serpl::redux::thunk::process_search::ProcessSearchThunk as redux_rs::middlewares::thunk::Thunk<serpl::redux::state::State,serpl::redux::action::Action,Api>>::execute::{{closure}}::hd5f1b3e537198a99
   2: 0x560e44f5391b - <redux_rs::middlewares::thunk::ThunkMiddleware as redux_rs::middleware::MiddleWare<State,redux_rs::middlewares::thunk::ActionOrThunk<State,Action,Inner>,Inner,Action>>::dispatch::{{closure}}::{{closure}}::ha741c79cf635aa84
   3: 0x560e44f588a5 - tokio::runtime::task::core::Core<T,S>::poll::h06c778d17f485a9c
   4: 0x560e44f363bc - tokio::runtime::task::harness::Harness<T,S>::poll::h1ae731c2002f8980
   5: 0x560e450bcc7f - tokio::runtime::scheduler::multi_thread::worker::Context::run_task::hc2f225f422fe803d
   6: 0x560e450bc232 - tokio::runtime::scheduler::multi_thread::worker::Context::run::hdf99b7809c667a70
   7: 0x560e450ccf88 - tokio::runtime::context::runtime::enter_runtime::h95da73ec15f54d37
   8: 0x560e450bbb28 - tokio::runtime::scheduler::multi_thread::worker::run::h3ebd290cf7a80b1f
   9: 0x560e450b9363 - <tokio::runtime::blocking::task::BlockingTask<T> as core::future::future::Future>::poll::h85223960b30ac9b0
  10: 0x560e450cfbd7 - tokio::runtime::task::core::Core<T,S>::poll::hf422ce8193c7e9ab
  11: 0x560e450b2c8a - tokio::runtime::task::harness::Harness<T,S>::poll::hf5f3fe3ff8e6f627
  12: 0x560e450b8af0 - tokio::runtime::blocking::pool::Inner::run::h291941b8c39533cf
  13: 0x560e450b96e7 - std::sys_common::backtrace::__rust_begin_short_backtrace::ha2e76d1920bf6c69
  14: 0x560e450cb739 - core::ops::function::FnOnce::call_once{{vtable.shim}}::ha1ea5053dde9518b
  15: 0x560e4524cbd5 - std::sys::pal::unix::thread::Thread::new::thread_start::h2770ac7f8882db09
  16: 0x7fdf1ce51383 - start_thread
  17: 0x7fdf1ced400c - __clone3
  18:        0x0 - <unresolved>"""
blinxen commented 4 months ago

The following line indicates that serpl can't find ripgrep:

cause = 'Failed to execute ripgrep: Os { code: 2, kind: NotFound, message: "No such file or directory" }'

That is however required according to the docs.

skeet70 commented 4 months ago

True, sorry about that!

yassinebridi commented 4 months ago

I will keep this opened, if this happens, it should give a clear message, will fix this. Thanks for the report