Various UX improvements

yassinebridi / serpl

A simple terminal UI for search and replace, ala VS Code.

MIT License

567 stars 4 forks source link

Various UX improvements #8

Open yassinebridi opened 5 months ago

yassinebridi commented 5 months ago

[x] Search Result pane: automatically selecte the first file, UP/DOWN keys support
[x] Fix to change search and replace modes.
[x] Better documentation around dialogs, and why there are confirmation dialogs.
[x] Better way to display help(Keyboard shortcuts, hints)
[x] Add context to lines in the preview pane, like what ripgrep does with -C <N>
[ ] Better way of selecting files, maybe new shortcuts like: selecting specific file to do some actions like delete those files in bulk, bulk selecting all files, etc..
[ ] Move between panes using Modifier + <num>

tranzystorekk commented 5 months ago

Just noticed this project on my Gihub wall, a really nice addition to the TUI tools out there! ❤️

I gave it a small test drive and the file selection pane feels really nice, I'd only consider replacing the delete action with a toggle action - that makes it IMO more visual and allows e.g. reselecting files in case a user changes their mind.

The preview pane left me wanting some additional context lines shown, like grep/ripgrep does with the -C <N> flag.

yassinebridi commented 5 months ago

Thanks 🙏,

Yes, i'm planning on adding selecting on both the search list, and the preview pane, it's better UX for sure. Also, nice suggestion on the context, i will add that to this list.

Yukaii commented 5 months ago

Thanks for making this fantastic TUI app!

I want to make a wish to support quickly jumping between the panels by number rows like what LazyGit does 🙏🏼

yassinebridi commented 5 months ago

Thanks 🙏, I initially supported that and removed it because there would be a conflict between inputs in the number.

What i can do for now is a modifier + number(eg: ctrl + 2). Would that work?

Yukaii commented 5 months ago

Sounds great for me!