yassineharbe / simile-widgets

Automatically exported from code.google.com/p/simile-widgets
0 stars 0 forks source link

Lenses uses "className" for all IE - but that does not work anymore in IE8 (needs "class") #428

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. make lens templates with class attributes for styling
2. try it in IE7 and IE8

What is the expected output? What do you see instead?
in both IE's "className" attribute is used (instead of "class") - that is 
needed to make it work in IE7 but in IE8. Code that needs to be changed is in 
lens.js around line 480.

What version of the product are you using? On what browser and what
operating system?
SIMILE Exhibit 2.2

Original issue reported on code.google.com by walter.j...@gmail.com on 4 Mar 2011 at 9:50

GoogleCodeExporter commented 9 years ago
Hi, just wondering if anybody knows when this bug might be fixed or if there is 
a workaround? Thanks! 

Original comment by emily.br...@duke.edu on 2 May 2011 at 12:39

GoogleCodeExporter commented 9 years ago

Original comment by ryan...@csail.mit.edu on 23 Jun 2011 at 9:59

GoogleCodeExporter commented 9 years ago

Original comment by ryan...@csail.mit.edu on 23 Jun 2011 at 10:40

GoogleCodeExporter commented 9 years ago
in lens.js, line#418  change  from 

name = "className";

to  

name = "class";

Then the classes come correctly in IE8+.

Original comment by rajeevka...@gmail.com on 14 Mar 2012 at 6:33

GoogleCodeExporter commented 9 years ago
After making the change, you can recreate the budle or edit the 
exhibit-bundle.js (2.2.0) and make same change on line#4375.

I hope this helps someone struggling on IE8, IE9 to make the lens format work 
correctly.

Original comment by rajeevka...@gmail.com on 14 Mar 2012 at 7:01