Crate doesn't compile without "json" feature due to unconfigurable usage of serde_json

yassun7010 / serde_valid

JSON Schema based validation tool using serde.

MIT License

45 stars 10 forks source link

Crate doesn't compile without "json" feature due to unconfigurable usage of serde_json #55

Closed AdamGS closed 6 months ago

AdamGS commented 7 months ago

While the "json" feature is optional and serde_json is marked as an optional dependency, its actually a required one because its used across the crate to format some errors, making it impossible to disable.

yassun7010 commented 6 months ago

Indeed!

I tried to move json to features for consistency in module structure, but there was an omission.

I will move it back to required.