search

yassun7010 / serde_valid

JSON Schema based validation tool using serde.
MIT License
43 stars 10 forks source link

Migrate from serde_yaml to serde_yml #80

Open ck3mp3r opened 3 weeks ago

ck3mp3r commented 3 weeks ago

As serde_yaml has been archived and is marked as deprecated it would be good to move to serde_yml, as it seems to be the successor.

yassun7010 commented 3 weeks ago

Thank you for raising the issue!

After serde_yaml was archived, no official replacement was specified.

I am positive about the migration, but would like to know if there is any information that would help me decide on serde_yaml.

ck3mp3r commented 3 weeks ago

I guess it is up to you to evaluate serde_yml and its goals going forward, considering it was forked from the original. The quote below by the forks maintainer:

If you are currently using serde-yaml in your projects, we recommend carefully evaluating your requirements and considering the stability and maturity of the original library as well as looking at the features and improvements offered by other YAML libraries in the Rust ecosystem.

Maybe consider reaching out to the new maintainer(s) and establish a joint path forward. Using another yaml serde project in your own library could potentially mean breaking changes.

I have created a PR with required changes to migrate as you most likely have seen already.

yassun7010 commented 3 weeks ago

PR is also confirmed. Thanks for your contribution!!

serde_yml disables issues and discussions, I can't find an appropriate contact point :(

I'm not used to this kind of communication without GitHub. How should I contact him in general?

ck3mp3r commented 3 weeks ago

PR is also confirmed. Thanks for your contribution!!

serde_yml disables issues and discussions, I can't find an appropriate contact point :(

I'm not used to this kind of communication without GitHub. How should I contact him in general?

You can reach him via his github handle, he has multiple social network contacts you can try. Also, what do you mean by PR is also confirmed? I see that the merge status checks etc cannot run, so the merge will never happen...

yassun7010 commented 3 weeks ago

Also, what do you mean by PR is also confirmed? I see that the merge status checks etc cannot run, so the merge will never happen...

What I meant to say is that I know you created PR, but I have not made the decision that we should move to serde_yml.

If I decide to move to serde_yml, I will merge the PR.