Detach/Attach not working as expected.

yasszu / bottom-navigation

Example of Android BottomNavigationView

https://developer.android.com/reference/com/google/android/material/bottomnavigation/BottomNavigationView

132 stars 17 forks source link

Detach/Attach not working as expected. #1

Closed Matt-Owens closed 6 years ago

Matt-Owens commented 6 years ago

The conditionals in MainActivity.kt are not firing ever.

if (fragment.isAdded) and if (fragment.isDetached)

This results in the fragment always being added, even when it was previously deattached and should be re-attached.

Any idea what is causing this behavior?

yasszu commented 6 years ago

Thank you for announcing. It was a bug as you said. It is need to get Fragment with findFragmentByTag before detaching/attaching Fragments. I have already fixed this bug. Please check #2.

Matt-Owens commented 6 years ago

Good catch! Works great now. Thanks so much for this great example.