search

yast / yast-installation

YaST module installation
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
16 stars 44 forks source link

another try at adressing the hidpi issue (bsc#1199020) #1049

Closed wfeldt closed 2 years ago

wfeldt commented 2 years ago

Problem

The previous attempt https://github.com/yast/yast-installation/pull/1019 doesn't work and runs into issues described in the above mentioned bug.

Solution (to be discussed)

Here is a proposal received via email from Karsten Nordsiek.

The patch will need some polishing but essentially the decision is now based on the screen width instead of the dpi number.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 40.746% when pulling f652a6bef4cacff28e387d4c6533a0df058130d2 on sw_10 into b4d1b1a1e837c598b92ed6b64ab365aa30f7f91b on master.

shundhammer commented 2 years ago

I am very sceptical about this approach. It's certainly not just the pixel width that matters; if that screen is very wide in reality (like those new ultra-wide curved screens), just assuming HiDPI because of that pixel width will certainly introduce new problems. That would mean just moving the problem around and making another group of users unhappy instead.

We really need to take the DPI into account, and that is calculated from the width in mm and the width in pixels. I have yet to see the first case where that didn't work on our side, setting the Xft.dpi X resource to a multiple of 48 as we do in our Yast2.call script.

AFAICS the problem lies elsewhere, possibly in the interaction between us and the Qt libs.

shundhammer commented 2 years ago

See also https://github.com/yast/yast-installation/pull/1057