yast / yast-installation

YaST module installation
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
16 stars 44 forks source link

ignore cpu_mitigations for bootloaders which do not support cpu mitig… #1093

Closed schubi2 closed 1 year ago

schubi2 commented 1 year ago

…ations e.g. none/systemd-boot

Problem

systemd-boot bootloader currently does not support cpu mitigation. So no proposal should be shown for this setting like "none" bootloader is already doing it. So this is more a generic solution for it.

Solution

Checking if the corresponding bootloader has a cpu_mitigations call.

Testing

coveralls commented 1 year ago

Coverage Status

coverage: 40.811%. remained the same when pulling dcd99020ee7cc7bc4c1eda77f7f8e9595b109ca5 on cpu_mitigations into 44200d2f3c0b5bed255ecb8f1debde54ab618bf1 on master.

jreidinger commented 1 year ago

change looks good, just please bump version and add changelog entry. Thanks

jreidinger commented 1 year ago

OK, one more change is required at https://github.com/yast/yast-installation/blob/master/src/lib/installation/dialogs/security.rb#L124 which use wrong name

yast-bot commented 1 year ago

:heavy_check_mark: Public Jenkins job #261 successfully finished :heavy_check_mark: Created OBS submit request #1109088

yast-bot commented 1 year ago

:heavy_check_mark: Internal Jenkins job #148 successfully finished