Drop fbiterm in Tumbleweed Installation

[shundhammer]

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1224053

Trello

https://trello.com/c/haqsYySu

Problem

We are using fbiterm for much improved support for nontrivial locales like Chinese, Japanese, Korean in NCurses. But fbiterm is part of the xiterm package (it's the framebuffer version of xiterm, hence FB-Iterm) which has been abandoned upstream many years ago. With the upcoming GCC 14, it has build problems. The maintainer of the xiterm package feels unable to continue supporting it; so we need to drop the xiterm package and with it fbiterm.

Fix

• ~Don't require xiterm in the YaST packages anymore.~ It turns out we never required xiterm or fbiterm in any YaST package: We always checked at runtime if /usr/bin/fbiterm was available and used it only if it was.

• Don't use fbiterm in the YaST startup scripts anymore. Strictly speaking, we could simply rely on the check if it was available, but this PR cleans up a lot of legacy that goes back a long time, and that obscured the code in the startup scripts.

Caveat

Installing in certain languages won't work anymore in NCurses (text mode). Those languages will use a fallback to English from now on; but only in NCurses. The Qt (graphical) installation will work as before.

Target Distributions

For now, only Tumbleweed / Factory / YaST master is affected. SLE-15 SPx and SLE-12 SPx will retain fbiterm.

Test

Manual test in a modified inst-sys with the new scripts

[coveralls]

coverage: 41.105%. remained the same when pulling 2efeda0ee297915f1fa2049f2343ddbc6e547ebc on huha-no-fbiterm into 68180ad75b5f46dbd63e1dff199a804659bf6fab on master.

[shundhammer]

See also https://github.com/openSUSE/installation-images/pull/708

[github-actions[bot]]

:x: Autosubmission job #9251920803 failed

[shundhammer]

@lslezak : This is the example for CI via GitHub failing because the image doesn't have /bin/diff.

[shundhammer]

Submitted manually with rake osc:sr to OBS openSUSE:Factory:

https://build.opensuse.org/request/show/1177300

[lslezak]

I have added the diffutils to the container image. Looks like it was removed from the base container, recently I had to add it elsewhere too...

[github-actions[bot]]

:white_check_mark: Autosubmission job #9251920803 successfully finished