search

yast / yast-installation

YaST module installation
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
16 stars 44 forks source link

Don't Block in AutoYaST Upgrade with Reboot Message [SLE-15-SP5] #1119

Closed shundhammer closed 2 months ago

shundhammer commented 2 months ago

Target Branch

This is for SLE-15-SP5. A merge to SLE-15-SP6, -SP7 and master / Factory will follow.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1181625

Trello

https://trello.com/c/jxGwssL6/

Problem

In certain situations, an AutoYaST upgrade may block with a pop-up dialog "The system will reboot now" message that does not continue after a timeout as it should; the user needs to confirm it interactively which is against the idea of an auto-upgrade.

Cause

The pop-up is suppressed only in Mode.autoinst, not also in Mode.autoupgrade.

Fix

Instead of just checking for Mode.autoinst, check for Mode.auto which includes both Mode.autoinst and Mode.autoupgrade.

See also https://github.com/yast/yast-yast2/blob/master/library/general/src/modules/Mode.rb#L283-L286

Related PRs

coveralls commented 2 months ago

Coverage Status

coverage: 40.913%. remained the same when pulling 38b7553b8cfeb80751a8d1b87acbea45303039a5 on huha-ay-upgrade-sp5 into ecc4aeb3191d14c162413413d169a24f1431c36d on SLE-15-SP5.

yast-bot commented 2 months ago

:heavy_check_mark: Internal Jenkins job #759 successfully finished :heavy_check_mark: Created IBS submit request #342269