search

yast / yast-network

YaST module network
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
14 stars 35 forks source link

Installation crashes when writing VLAN configuration into NetworkManager #1336

Closed mchf closed 1 year ago

mchf commented 1 year ago

Problem

Installation crashed when installing MicroOS (5.3) with configured vlan.

This bug is not MicroOS specific. First crucial prerequisite for the bug to happen was that target was configured to use NetworkManager as network service. The issue happened in test where user connected to installation source via vlan device. The configuration of the device itself is not important. What caused trouble was vlan id. Say you have device eth0.1006 where 1006 is vlan id. At the end of installation when network configuration is being stored installer crashed when writing NetworkManager's configuration via augeas to the target.

Solution

Problem was caused by storing vlan id in wrong format. YaST passed integer where String was expected

Testing

coveralls commented 1 year ago

Coverage Status

coverage: 80.014% (+0.07%) from 79.944% when pulling 67c64ba7f4ed76158e1c91b026a7a05a6448da3e on mchf:bsc1211431-nm-vlan-crash into 3ccab4f1b968a88ba04c2d89815c752be8d2d67e on yast:SLE-15-SP3.

yast-bot commented 1 year ago

:x: Internal Jenkins job #16 failed