search

yast / yast-network

YaST module network
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
14 stars 35 forks source link

Guard secret attributes against leaking to the logs [SLE-15-SP2] #1361

Closed shundhammer closed 7 months ago

shundhammer commented 7 months ago

Target Branch

This is for SLE-15-SP2.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1221194

Trello

https://trello.com/c/6SAaaYZ3/

Problem

Secret attributes of the wifi connection object might leak to the logs, e.g. if methods like inspect() are used.

Solution

Mark them as secret with secret_attr from YaST2::SecretAttributes.

Caveat

In this branch, secret_attributes.rb still lives in the Y2Storage namespace and in the yast-storage repo. From SLE-15-SP4 on, it lives in the Yast namespace and in the yast-yast2 repo.

Test

Related PRs

teclator commented 7 months ago

Submitted manually: https://build.suse.de/request/show/323983