Guard secret attributes against leaking to the logs [SLE-15-SP3]

shundhammer commented 7 months ago

Target Branch

This is the merge PR of #1361 to SLE-15-SP3.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1221194

Trello

https://trello.com/c/6SAaaYZ3/

Problem

Secret attributes of the wifi connection object might leak to the logs, e.g. if methods like inspect() are used.

Solution

Mark them as secret with secret_attr from YaST2::SecretAttributes.

Caveat

In this branch, secret_attributes.rb still lives in the Y2Storage namespace and in the yast-storage repo. From SLE-15-SP4 on, it lives in the Yast namespace and in the yast-yast2 repo.

Test

Extended and executed the unit tests with packages from the same branch.

Related PRs

PoC PR: #1360
PR for SLE-15-SP2: #1361

coveralls commented 7 months ago

coverage: 80.044% (-0.01%) from 80.058% when pulling 1756738581b86eb8917611ecef09f9709d726f82 on huha-pw-leak-15-3 into 35c2a7508f4fa2d7f381d0f222de0e253090fa2f on SLE-15-SP3.

yast-bot commented 7 months ago

:heavy_check_mark: Internal Jenkins job #19 successfully finished :heavy_check_mark: Created IBS submit request #323985

yast / yast-network