Guard secret attributes against leaking to the logs [SLE-15-SP5]

shundhammer commented 7 months ago

Target Branch

This is the merge PR of #1363 to SLE-15-SP5.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1221194

Trello

https://trello.com/c/6SAaaYZ3/

Problem

Secret attributes of the wifi connection object might leak to the logs, e.g. if methods like inspect() are used.

Solution

Mark them as secret with secret_attr from YaST2::SecretAttributes.

Test

Extended and executed the unit tests with packages from the same branch.

Related PRs

PoC PR: #1360
PR for SLE-15-SP2: #1361
Merge PR to SLE-15-SP3: #1362
Merge PR to SLE-15-SP4: #1363

coveralls commented 7 months ago

coverage: 80.584% (+0.03%) from 80.555% when pulling afc12ab85749e92dfba39e829a9d4fc1a76c25ea on huha-pw-leak-15-5 into 1d8ba6a3b4e4d08d56bc15c6d02b83db29ebdac5 on SLE-15-SP5.

yast-bot commented 7 months ago

:x: Internal Jenkins job #769 failed

yast-bot commented 7 months ago

:heavy_check_mark: Internal Jenkins job #770 successfully finished :heavy_check_mark: Created IBS submit request #324055

yast / yast-network