Guard secret attributes against leaking to the logs [SLE-15-SP6]

shundhammer commented 7 months ago

Target Branch

This is the merge PR of #1364 to SLE-15-SP6.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1221194

Trello

https://trello.com/c/6SAaaYZ3/

Problem

Secret attributes of the wifi connection object might leak to the logs, e.g. if methods like inspect() are used.

Solution

Mark them as secret with secret_attr from YaST2::SecretAttributes.

Test

Extended and executed the unit tests with packages from the same branch.

Related PRs

PoC PR: #1360
PR for SLE-15-SP2: #1361
Merge PR to SLE-15-SP3: #1362
Merge PR to SLE-15-SP4: #1363
Merge PR to SLE-15-SP5: #1364

coveralls commented 7 months ago

coverage: 80.584% (-0.02%) from 80.607% when pulling b3597d3bb1d0cf9f2a109ece496029a75c4fa93e on huha-pw-leak-15-6 into 9b0050dde92f9dcdc498f8716e60e9aa55627e72 on SLE-15-SP6.

yast-bot commented 7 months ago

:heavy_check_mark: Internal Jenkins job #6 successfully finished :heavy_check_mark: Created IBS submit request #323993

yast / yast-network