Guard secret attributes against leaking to the logs [master]

shundhammer commented 7 months ago

Target Branch

This is the merge PR of #1365 to master.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1221194

Trello

https://trello.com/c/6SAaaYZ3/

Problem

Secret attributes of the wifi connection object might leak to the logs, e.g. if methods like inspect() are used.

Solution

Mark them as secret with secret_attr from YaST2::SecretAttributes.

Test

Extended and executed the unit tests with packages from the same branch.

Related PRs

PoC PR: #1360
PR for SLE-15-SP2: #1361
Merge PR to SLE-15-SP3: #1362
Merge PR to SLE-15-SP4: #1363
Merge PR to SLE-15-SP5: #1364
Merge PR to SLE-15-SP6: #1365

coveralls commented 7 months ago

coverage: 80.784% (+0.003%) from 80.781% when pulling c974a08e1f5f96945110440ff8ba0ae0b64e3e0d on huha-pw-leak-master into 2ac81c0d38ab61112f059e97af6b3a1dc60db03a on master.

yast-bot commented 7 months ago

:x: Internal Jenkins job #606 failed

yast-bot commented 7 months ago

:heavy_check_mark: Internal Jenkins job #607 successfully finished :heavy_check_mark: Created OBS submit request #1157994

yast / yast-network