yast / yast-printer

YaST module printer
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
3 stars 6 forks source link

Fix AutoYaST schema #7

Closed imobachgs closed 8 years ago

imobachgs commented 8 years ago

printer section is not included in AutoYaST scheme. It looks like the AutoInstSchema declaration is missing.

imobachgs commented 8 years ago

I've found two additional issues here. I'll fix them again and I'll remove the [do not merge] label.

imobachgs commented 8 years ago

@mvidner I've added two missing sections to this schema (taking all the possible values from the manpages). Now it validates the profile given by the customer. Specially the server_settings looks repetitive to me so I guess I could do something like:

cups_listentry = element cups_listentry { LIST, element listentry { text }* }

server_settings =
  element server_settings { 
    element AccessLog { cups_listentry }? &
    element Allow { cups_listentry }? &
...

Or maybe there's a better way to do that. Any hint?

mvidner commented 8 years ago

Yes, except the part with element cups_listentry is wrong as that would introduce an actual XML tag. This should work instead:

cups_listentries = LIST, element listentry { text }*

server_settings =
  element server_settings { 
    element AccessLog    { cups_listentries }? &
    element Allow        { cups_listentries }? &
...
imobachgs commented 8 years ago

@mvidner Oh, I see. I've submitted an updated version. Thanks!

mvidner commented 8 years ago

Thank you, LGTM.

imobachgs commented 8 years ago

Thank you for the reviews! Merging...