search

yast / yast-ruby-bindings

YaST module ruby-bindings
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
6 stars 14 forks source link

A missing `textdomain` declaration is optionally an exception #230

Closed mvidner closed 5 years ago

mvidner commented 5 years ago

In https://bugzilla.suse.com/show_bug.cgi?id=1130822 we have untranslated text in a dialog, even though the translators did work that particular string. The reason is a missing textdomain declaration in a class.

This kind of error is a programmer error which should be caught very early during the development or testing, so users should not see them. BUT we may have allowed this kind of bugs to creep in over time so it would be a nuisance to start failing in users faces now. -> Make it opt-in for testing.

The exception is enabled by export Y2STRICTTEXTDOMAIN=1

no-textdomain

mvidner commented 5 years ago

@rwx788 Rodion, I would like to enable this in openQA tests across all of YaST (post-SP1) by setting the environment variable Y2STRICTTEXTDOMAIN=1. Does it make sense? It it easy to do?

yast-bot commented 5 years ago

:heavy_check_mark: Public Jenkins job #10 successfully finished :heavy_check_mark: Created OBS submit request #703443

mvidner commented 5 years ago

Enabling this in RSpec tests will also help, let's find a good place to put it in

rwx788 commented 5 years ago

@rwx788 Rodion, I would like to enable this in openQA tests across all of YaST (post-SP1) by setting the environment variable Y2STRICTTEXTDOMAIN=1. Does it make sense? It it easy to do?

That totally makes sense. We already parse logs for such errors, and we have one scenario specifically dedicated to this case, to click more menus, etc. I'll create backlog item for it. Thanks!

mvidner commented 3 years ago

@rwx788 just a reminder that this would catch some untranslated texts, but I don't know where to enable it, and what is a good time in the release cycle for it

rwx788 commented 3 years ago

@rwx788 just a reminder that this would catch some untranslated texts, but I don't know where to enable it, and what is a good time in the release cycle for it

Hi @mvidner! We have already enabled Y2STRICTTEXTDOMAIN in couple of scenarios. Do you think it makes sense to enable in all the tests by default?