Closed jreidinger closed 4 years ago
It looks OK but the Travis failure is messy, I can't tell whether this PR is causing it.
@mvidner me neither and it is strange that only push one and not pr one failed. Restarting job to see if it is just temporary issue.
@mvidner with additional debug output it now prints segfault. Sadly I cannot reproduce it locally, as rake osc:build
skips this test ( so also BS is not affected ). Not sure what case it as I do not have core dump, but this change does not look like reason for segfault ( which is probably race condition ).
Sadly I cannot reproduce it locally, as
rake osc:build
skips this test
It skips because tmux is not installed. That can be solved with rake osc:build["-x tmux"]
... and then it passes for me. :woman_shrugging:
I tried various ways to reproduce the test failure locally but it always succeeded. So I restarted the Travis job and now it is green.
:heavy_check_mark: Internal Jenkins job #9 successfully finished :heavy_check_mark: Created IBS submit request #208242
Implement proper exit codes of yast program
It is currently identical behavior as in original y2core. References: https://github.com/yast/yast-core/blob/master/liby2/src/genericfrontend.cc#L777 https://github.com/yast/yast-core/blob/master/liby2/src/include/y2/exitcodes.h#L25 https://github.com/yast/yast-core/blob/master/liby2/src/genericfrontend.cc#L115
replaces https://github.com/yast/yast-ruby-bindings/pull/222