search

yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage
http://yast.github.io/
GNU General Public License v2.0
13 stars 19 forks source link

Replace exfat-utils with exfatprogs #1214

Open Vogtinator opened 3 years ago

Vogtinator commented 3 years ago

exfat-utils was apparently replaced by exfatprogs, and SLE doesn't even have the former.

https://github.com/yast/yast-storage-ng/blob/e505276388da1fd6fb1bb49de7321e4dd63629f1/src/lib/y2storage/storage_feature.rb#L78

ancorgs commented 3 years ago

As far as I can see in a quick check:

So switching to exfatprogs looks like a safe bet. Having said so, do you have any pointer to the explanation about why exfat-utils was dropped in 15.3?

Vogtinator commented 3 years ago

Having said so, do you have any pointer to the explanation about why exfat-utils was dropped in 15.3?

The explanation is that SP3 already had exfatprogs. So there's not much substance behind that reasoning...

Vogtinator commented 3 years ago

According to https://lore.kernel.org/lkml/004701d6194c$0d238990$276a9cb0$@samsung.com/, they're both the same project, but looking at git, exfat-utils is something different. At least I'm even more confused now.

ancorgs commented 3 years ago

Both packages provide binaries in /usr/sbin with the basic names you would expect (fsck.exfat, mkfs.exfat, exfatlabel) and, thus, the packages conflict with each other.

But there is an important difference. The package exfat-utils also provides symlinks at /sbin for those binaries, while the package exfatprogs only provides the /usr/sbin/ paths. Why is that important? Because as far as I can see, libstorage-ng expects those files in /sbin. https://github.com/openSUSE/libstorage-ng/blob/master/storage/Utils/StorageDefines.h#L138

So before changing this in yast2-storage-ng, we should adapt libstorage-ng to use the binaries at /usr/sbin, which should be compatible with both packages.

@aschnell Am I right?

aschnell commented 3 years ago

Yes, using /usr/sbin should work for both packages. But users setting mkfs option might face compatibility problems since the tools have different options.

ancorgs commented 3 years ago

Now tracked at https://bugzilla.suse.com/show_bug.cgi?id=1184489 and (for the YaST team) at https://trello.com/c/N7gz5WP0/

RokeJulianLockhart commented 11 months ago

@ancorgs, considering that https://bugzilla.suse.com/show_bug.cgi?id=1184489 is RESOLVED FIXED, should this be closed?

ancorgs commented 11 months ago

I will check.

ancorgs commented 11 months ago

This is only fixed in the libstorage-ng side (which was the critical part). But YaST would still try to add exfat-utils to the selection of packages (unsuccessfully). That still needs to be improved.