yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage
http://yast.github.io/
GNU General Public License v2.0
14 stars 20 forks source link

Improve show details for NFS devices #1285

Closed joseivanlopez closed 2 years ago

joseivanlopez commented 2 years ago

Problem

As part of improving the integration with yast2-nfs-client (see https://github.com/yast/yast-storage-ng/pull/1283), it was decided to always show defaults instead of an empty string when the NFS has no mount options. This is done everywhere, namely lists and forms. But there was one more place: the popup to show the details of a device (Device -> Show Details menu option).

Solution

Use defaults in the device details when there are no mount options.

Testing

Screenshots

Screenshot from 2022-02-03 16-10-40

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.0004%) to 97.424% when pulling 02e23f6e77fc4febccdc6a445c91665f673dcebb on joseivanlopez:fix-nfs-details into 0786c0f0430d3a9d5feb44048cfbb0505bdb3ae1 on yast:master.

yast-bot commented 2 years ago

:heavy_check_mark: Internal Jenkins job #220 successfully finished :heavy_check_mark: Created IBS submit request #264078

yast-bot commented 2 years ago

:heavy_check_mark: Public Jenkins job #427 successfully finished :heavy_check_mark: Created OBS submit request #951536