yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage
http://yast.github.io/
GNU General Public License v2.0
14 stars 20 forks source link

Fix empty help in some Partitioner dialogs (bsc#1194274) #1297

Closed mvidner closed 2 years ago

mvidner commented 2 years ago

Problem

Some dialogs in the partitioner have a Help button that pops up an empty window.

Solution

These fixes work via a method of a base class of all these dialogs, Y2Partitioner::Dialogs::Popup#set_help_text.

A better fix would be to use a common mechanism of CWM+Wizard: Wizard.SetHelpText relying on existence of a widget with Id(:WizardDialog) but that is risky for SLE15-SP4

Testing

Tested manually. For easier testing, the dialogs are:

Screenshots

Working help popups with this fix:

nohelp-format-options nohelp-fstab-options nohelp-import-mount-points nohelp-clone-partition-table

yast-bot commented 2 years ago

:heavy_check_mark: Internal Jenkins job #5 successfully finished :heavy_check_mark: Created IBS submit request #270066