search

yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage
http://yast.github.io/
GNU General Public License v2.0
14 stars 20 forks source link

Fix empty help in some Partitioner dialogs (bsc#1194274) master #1298

Closed mvidner closed 2 years ago

mvidner commented 2 years ago

See #1297, merging it from SLE-15-SP4 to master...

These fixes work via a method of a base class of all these dialogs, Y2Partitioner::Dialogs::Popup#set_help_text.

A better fix would be to use a common mechanism of CWM+Wizard: Wizard.SetHelpText relying on existence of a widget with Id(:WizardDialog) but that is risky for SLE15-SP4

so here I'm replacing all of it with a better fix :smile:

CWM.MergeHelps is the focal point, see where its result goes to understand the following fix:

The critical piece is having a widget with ID(:WizardDialog) because that is the widget to which CWM will assign the merged help texts of the individual widgets, using Wizard.SetContentsButtons or Wizard.RestoreHelp.

Once this is in place, we can remove many methods of Y2Partitioner::Dialogs::*

Tested manually.

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.04%) to 97.821% when pulling 346e29cbaf839f810a4c8e0c61a2c71eafd2221d on empty-help-in-dialogs-m into 40f59155b864b11e2101592f13f2110b6ce27a1e on master.

yast-bot commented 2 years ago

:heavy_check_mark: Public Jenkins job #436 successfully finished :heavy_check_mark: Created OBS submit request #971093