Closed imobachgs closed 2 years ago
:heavy_check_mark: Public Jenkins job #443 successfully finished :heavy_check_mark: Created OBS submit request #1006181
:heavy_check_mark: Internal Jenkins job #229 successfully finished :heavy_check_mark: Created IBS submit request #280769
Problems
StorageManager
is coupled with UI. The IssuesManager#report_probing_issues is called if an issue is registered during the probing phase (see manage_probing_issues method.Solution
To decouple the UI from the probing process, we decided to rely on the callbacks mechanism. However, we found out that there are two use-cases for those callbacks:
So instead of just extending the
Callbacks::Probe
, we decided to keep this class as an implementation details and inject a new callback class.At this point, it only implements a#report_probing_issues
method and the API is still under discussion. Event the method name looks redundant (why about justreport_issues
?).Last but not least, we decided to get rid of the
IssuesManager
class, as it is not needed by theDevicegraph
class anymore.To do