yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage
http://yast.github.io/
GNU General Public License v2.0
14 stars 20 forks source link

Add user probe callbacks #1309

Closed imobachgs closed 2 years ago

imobachgs commented 2 years ago

Problems

Solution

To decouple the UI from the probing process, we decided to rely on the callbacks mechanism. However, we found out that there are two use-cases for those callbacks:

So instead of just extending the Callbacks::Probe, we decided to keep this class as an implementation details and inject a new callback class.

At this point, it only implements a #report_probing_issues method and the API is still under discussion. Event the method name looks redundant (why about just report_issues?).

Last but not least, we decided to get rid of the IssuesManager class, as it is not needed by the Devicegraph class anymore.

To do

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-0.02%) to 97.807% when pulling 75576ab15a46630bb10ea7c075634d1728f29d14 on add-user-probe-callbacks into 24a7faa45d27139ddc141bc09d50b34b3d699c7b on master.

yast-bot commented 2 years ago

:heavy_check_mark: Public Jenkins job #443 successfully finished :heavy_check_mark: Created OBS submit request #1006181

yast-bot commented 2 years ago

:heavy_check_mark: Internal Jenkins job #229 successfully finished :heavy_check_mark: Created IBS submit request #280769