Adapt test to behavior change in libstorage-ng

ancorgs commented 1 year ago

Problem

This was changed in libstorage-ng https://github.com/openSUSE/libstorage-ng/pull/900

Before that, ms_dos_ptable.partition_id_supported?(Y2Storage::PartitionId::UNKNOWN) returned false. Now it returns true.

The change is actually safe for the current code-base of yast-storage-ng (see below), but it broke the unit tests we intentionally have in place to detect changes in the libstorage-ng API (so we can manually check if there is any problematic implication).

Solution

Just adapt the test to the new behavior of libstorage-ng. We verified the change is safe because:

PartitionTables::Base#supported_partition_ids already filters UNKNOWN out. Among other things, that already guarantees UNKNOWN is never offered as an option in the UI.
Calls to whatever_ptable.partition_id_supported?(Y2Storage::PartitionId::UNKNOWN) have always returned true for partition tables of type DASD and GPT and has never been a problem so far. Actually MS-DOS was the exception here.

coveralls commented 1 year ago

Coverage remained the same at 97.807% when pulling b20bdcc61f8e3afd20970ad834161a89feda422b on ancorgs:fix_test_supported into ad3c7b5d56c4a05afdeb92f876e934790eba2eb9 on yast:master.

yast-bot commented 1 year ago

:heavy_check_mark: Public Jenkins job #444 successfully finished :heavy_check_mark: Created OBS submit request #1030324

yast-bot commented 1 year ago

:x: Internal Jenkins job #230 failed

yast-bot commented 1 year ago

:heavy_check_mark: Internal Jenkins job #231 successfully finished :heavy_check_mark: Created IBS submit request #283189

yast / yast-storage-ng

Adapt test to behavior change in libstorage-ng #1311

Problem

Solution