search

yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage
http://yast.github.io/
GNU General Public License v2.0
14 stars 20 forks source link

bsc#1209697: fix widgets titles in the dialog to select a partitioning schema #1325

Closed imobachgs closed 1 year ago

imobachgs commented 1 year ago

Problem

Although strings are marked for translation, they are not properly translated later.

https://bugzilla.suse.com/show_bug.cgi?id=1209697

Solution

Fix the calls to _ to act on the marked test.

Testing

Screenshots

Widgets ![translated-partitioning-scheme](https://user-images.githubusercontent.com/15836/229109147-3732e7e0-7be3-4cd1-8063-c201ee1ea6f5.png)
Help text ![help-text](https://user-images.githubusercontent.com/15836/229112864-7324016b-b159-4fac-98cf-09d3f717efcc.png)
coveralls commented 1 year ago

Coverage Status

Coverage: 97.757%. Remained the same when pulling bd8db71c4f2146219241607a4c53bd0d9eb00201 on bsc-1209697 into 45d39c8a30939bbefaafece5f617a8ffcfff9e48 on SLE-15-SP5.

imobachgs commented 1 year ago

LGTM.

I assume this also fixes the "separate LVMs" case (which is only used for SUMA).

Yes, I tweaked the code to display that widget and it got translated.

yast-bot commented 1 year ago

:heavy_check_mark: Internal Jenkins job #750 successfully finished :heavy_check_mark: Created IBS submit request #293457