search

yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage
http://yast.github.io/
GNU General Public License v2.0
14 stars 20 forks source link

Ensure thin LVM volumes are exported when cloning the system #1327

Closed ancorgs closed 1 year ago

ancorgs commented 1 year ago

Problem

Fix for bsc#1209725

When exporting the AutoYaST profile (ie. when cloning the system), LVM thin volumes were ignored.

According to AutoYaST documentation, the thin pool and all its thin volumes must be included as <partition> elements within the <drive> that represents the LVM volume group.

In the devicegraph, the thin pool and its thin volumes are not represented at the same hierarchy level. The volumes are nested into the pool. That was overlooked when implementing the code to clone the system.

Solution

Ensure all logical volumes are taken into consideration, despite the nesting. With that, the exported profile includes the thin pool as well as all its thin volumes.

Testing

coveralls commented 1 year ago

Coverage Status

Coverage: 97.755%. Remained the same when pulling 285387cad3cfa58b3d5cf81616edbe3945d104da on ancorgs:export_thin into 7d67d4a2ad22a0b2db2c49482d7bbdd74d7240aa on yast:master.

yast-bot commented 1 year ago

:heavy_check_mark: Public Jenkins job #457 successfully finished