search

yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage
http://yast.github.io/
GNU General Public License v2.0
14 stars 20 forks source link

[SP5] Improve display of Dell BOSS #1329

Closed ancorgs closed 1 year ago

ancorgs commented 1 year ago

Problem

Some things has changed regarding BOSS devices manufactured by Dell. That leaded to the creation of bug#1200975.

From the discussions in the bug report, we identified two things that could be improved in the YaST side.

  1. The regexp to detect a Dell BOSS disk needs to be updated. Originally Dell stated that all BOSS devices would contain the string "DELLBOSS" as part of the model (https://jira.suse.com/browse/SLE-17578). Looks like that's not true anymore. According to a comment at the mentioned bug#1200975, the new criteria is "the model string will always have both Dell and BOSS in some order".
  2. For a typical disk, the column "Type" in the Expert Partitioner is computed as device.vendor + device.model (both fields taken from hwinfo). But that's redundant because "model" in hwinfo is a combination of vendor + device with quite some added heuristics to make the result nice looking.

Solution

Testing

Added new unit tests

Screenshots

Type column before the change.

before

Type column after the change.

after

coveralls commented 1 year ago

Coverage Status

Coverage: 97.757% (+0.0003%) from 97.757% when pulling 2c3cd2da6d03a9a870ad2f9f9f066fb2f975626e on ancorgs:like_a_boss_sp5 into 4030ab3e1abaed2c393522fb87f72a74f1e65b7d on yast:SLE-15-SP5.

ancorgs commented 1 year ago

BOSS is an acronym and has always being represented in capital letters in absolutely all previous conversations. So let's hope Dell keeps being consistent here. :wink:

I decided to use IGNORECASE for "dell" to support both "DELL" and "Dell", but I don't think the same justifies for the "BOSS" case (I don't foresee any alternative capitalization there).

yast-bot commented 1 year ago

:heavy_check_mark: Internal Jenkins job #751 successfully finished :heavy_check_mark: Created IBS submit request #294226