[SP5] Guided Setup: display a hint for disks with sensible transports

[ancorgs]

Problem

Described and discussed at https://bugzilla.suse.com/show_bug.cgi?id=1209588

The screen of the Guided Setup used to select the target disk(s) shows some information about each disk to make it possible to identify them.

But deciding which information to display is VERY tricky:

• YaST interface is designed to fit perfectly in text mode with 80 columns and 24 lines. That implies a lot of text and space economy.
• Many systems contains dozens of disks.
• Although some advanced users may appreciate details about the model of the disk or the controller, those are long and complex strings that are meaningless for most users.
• ...and many other considerations...

As a reasonable compromise, YaST displays the following information for each disk:

• The device name
• The total size
• The list of operating systems installed into it
• Whether the disk is removable (USB, Firewire or SD Card)
• A specific label if the disk is a DELL BOSS device

That was reported to not be enough in the case in which both local and remote NVMe disks are present in the system. There is nothing in the previous list that would allow to distinguish the remote from the local ones.

Solution

As a quick fix for SLE-15-SP5, just display the data transport in some special cases.

This displays the internal identifier of the transport, that is something like fcoe or tcp. Nothing too nice. Eg.

• /dev/sda, 500 GiB, iscsi, SLES-12

Testing

Extended unit tests

[coveralls]

Coverage: 97.751% (+0.0002%) from 97.75% when pulling cf949f6e0296bdefac43feba8e09ee7ac2e3c709 on ancorgs:bsc1209588_sp5 into 4af0e59801545484eeef5eac139c263ef488ae8d on yast:SLE-15-SP5.

[yast-bot]

:heavy_check_mark: Internal Jenkins job #753 successfully finished :heavy_check_mark: Created IBS submit request #296200