search

yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage
http://yast.github.io/
GNU General Public License v2.0
13 stars 19 forks source link

error from nvme-cli missing #1343

Closed moozaad closed 1 year ago

moozaad commented 1 year ago

Version : 4.6.11-1.1

If nvme-cli tools is missing, the partition just throws an error at launch. It would be nice if it requested to install it or it could be added as a package recommends.

image

joseivanlopez commented 1 year ago

Hi! Thanks for reporting. Theoretically, this problem was already fixed, see https://bugzilla.suse.com/show_bug.cgi?id=1172866.

Could you please attach your YaST logs to the bug report? See https://en.opensuse.org/openSUSE:Report_a_YaST_bug#Attachments_-_y2logs.2C_hwinfo_etc.

joseivanlopez commented 1 year ago

BTW, were that NVME devices attached to the system at installation time or afterwards? Because YaST should install nvme-cli if needed.

aschnell commented 1 year ago

Why nvme-cli is missing I cannot say. But libstorage-ng does not report this correctly. With a fix I'll merge within the next hour YaST installs nvme-cli (for me).

moozaad commented 1 year ago

@joseivanlopez

Hi! Thanks for reporting. Theoretically, this problem was already fixed, see https://bugzilla.suse.com/show_bug.cgi?id=1172866.

I did search bugzilla first. Unfortunately that's a private report. You are not authorized to access bug #1172866. Typically happens with half the bugs I report for opensuse 🤣

Could you please attach your YaST logs to the bug report? See https://en.opensuse.org/openSUSE:Report_a_YaST_bug#Attachments_-_y2logs.2C_hwinfo_etc.

I'll see what I can do tomorrow.

BTW, were that NVME devices attached to the system at installation time or afterwards? Because YaST should install nvme-cli if needed.

It's a tumbleweed installation dating from when it was first launched. Installation disk is SATA SSD. NVME have been in for years but I don't often launch partitioner/storage-ng. Latest tumbleweed snapshot as of today.

For a nice user experience, I would expect the same as bootloader, where it auto installs packages it needs for the job at launch. At very least a suggest: in the spec to install. https://build.opensuse.org/package/view_file/YaST:Head/libstorage-ng/libstorage-ng.spec?expand=1

joseivanlopez commented 1 year ago

Could you please attach your YaST logs to the bug report? See https://en.opensuse.org/openSUSE:Report_a_YaST_bug#Attachments_-_y2logs.2C_hwinfo_etc.

I'll see what I can do tomorrow.

Don't worry. The bug was already confirmed and fixed, see https://github.com/openSUSE/libstorage-ng/pull/936.

For a nice user experience, I would expect the same as bootloader, where it auto installs packages it needs for the job at launch. At very least a suggest: in the spec to install. https://build.opensuse.org/package/view_file/YaST:Head/libstorage-ng/libstorage-ng.spec?expand=1

Yes, that is how it is supposed to work with the fix above.

Thanks!