yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage
http://yast.github.io/
GNU General Public License v2.0
14 stars 20 forks source link

Honor proposal encryption from ProductFeatures #1344

Closed ancorgs closed 1 year ago

ancorgs commented 1 year ago

Problem

We want to make it possible for the Common Criteria role to provide an encryption password, so the partitioning proposal uses encryption by default.

And we want to do so in the less intrusive possible way, since we want the change to land at already released branches like 15.4 and 15.5.

Solution

On the one hand, we implemented https://github.com/yast/system-role-common-criteria/pull/10, to make the Common Criteria role dialog ask for the encryption password and store it at the field encryption of the ProductFeatures.

On this pull request, we make sure the storage GuidedProposal honors the mentioned field. The storage proposal already took all its default settings from the ProductFeatures, but encryption was not previously considered because it makes no sense to define a given password for all the installations of a product. But ProductFeatures is actually a very handy mechanism to store this value without affecting any other part of the code.

Testing

yast-bot commented 1 year ago

:heavy_check_mark: Internal Jenkins job #11 successfully finished :heavy_check_mark: Created IBS submit request #302453