Fix a bug when formatting a full disk as Btrfs with snapshots

yast / yast-storage-ng

Rewrite of https://github.com/yast/yast-storage

http://yast.github.io/

GNU General Public License v2.0

13 stars 19 forks source link

Fix a bug when formatting a full disk as Btrfs with snapshots #1385

Closed ancorgs closed 1 month ago

ancorgs commented 1 month ago

Problem

This bug at Agama was reported https://github.com/openSUSE/agama/issues/1339

Turns out the root of the error was an uncaught exception at the GuidedProposal caused because YaST was trying to adjust the sizes of the root device to fulfill the Btrfs-related settings... but such a device was a disk instead of an LV or partition.

Solution

Added the same guard we have in other parts of DevicesPlanner (eg. adjust_sizes).

Testing

Added a new unit test
Tested manually with Agama. It solves the reported bug.

coveralls commented 1 month ago

coverage: 97.804%. remained the same when pulling ace78c6dc83a0d325ede9d81babc2cc05bbb7930 on ancorgs:fix-agama-btrfs-disk into 034d1fb3d1a57ff36f8676fa7e1d44af54c19ae9 on yast:master.

coveralls commented 1 month ago

coverage: 97.804%. remained the same when pulling f90b6d57fe621a7ef5a546bfc85b1ca2938477e6 on ancorgs:fix-agama-btrfs-disk into 034d1fb3d1a57ff36f8676fa7e1d44af54c19ae9 on yast:master.

coveralls commented 1 month ago

coverage: 97.804%. remained the same when pulling 60a876a8b4419b1222699bcabb10f28d8acc0598 on ancorgs:fix-agama-btrfs-disk into 034d1fb3d1a57ff36f8676fa7e1d44af54c19ae9 on yast:master.

yast-bot commented 1 month ago

:heavy_check_mark: Internal Jenkins job #1158 successfully finished :heavy_check_mark: Created OBS submit request #1180916