search

yast / yast-yast2

YaST module yast2
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
55 stars 44 forks source link

Fix #current_items #1114

Closed joseivanlopez closed 3 years ago

joseivanlopez commented 3 years ago

Problem

Last changes in CWM (see https://github.com/yast/yast-yast2/pull/1113) can make unit tests to fail. The method #current_items returns nil in unit tests, so the test will fail when ComboBox#value= tries to map over nil.

See https://github.com/yast/yast-yast2/pull/1113#pullrequestreview-525536006.

Solution

Ensure that #current_items always returns a list.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.003%) to 32.426% when pulling 870b253f5d421c8b4c78cc9e772be9706dd42f4e on joseivanlopez:fix_current_items into 20ed56eefc436f57b441e86de4897a7ee07af59c on yast:master.

yast-bot commented 3 years ago

:heavy_check_mark: Public Jenkins job #263 successfully finished :heavy_check_mark: Created OBS submit request #846593

yast-bot commented 3 years ago

:heavy_check_mark: Internal Jenkins job #129 successfully finished :heavy_check_mark: Created IBS submit request #230098