search

yast / yast-yast2

YaST module yast2
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
55 stars 44 forks source link

Revert current items #1116

Closed teclator closed 3 years ago

teclator commented 3 years ago

Problem

A bug was reported recently as consequence of #1044 . The problem is that when the ComboBox is editable and the value is not present in the list of items, the list of items is modified using change_items with the original items, a list that could have been modified like it is in the yast-network essid widget.

So, it was proposed to check the current widget items instead of the items list but as @shundhammer pointed in https://bugzilla.suse.com/show_bug.cgi?id=1178832#c21, we created and inconsistency as we were not converting the list of Items to an Array<string, string>.

Solution

Revert the addition of the current_items method and fix the bug reported modifying yast2-network directly.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.004%) to 32.436% when pulling 3e42aced4ab2cb1ec298f42c7bb4945d0ceba684 on revert_current_items into 6c0ec689bfeb4ff3449356fb88c159c604f1f782 on master.

yast-bot commented 3 years ago

:heavy_check_mark: Public Jenkins job #265 successfully finished :heavy_check_mark: Created OBS submit request #850676

yast-bot commented 3 years ago

:heavy_check_mark: Internal Jenkins job #131 successfully finished :heavy_check_mark: Created IBS submit request #231372