search

yast / yast-yast2

YaST module yast2
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
55 stars 44 forks source link

bsc#1180142: do not use 'installation-helper' to create snapshots #1125

Closed imobachgs closed 3 years ago

imobachgs commented 3 years ago

YaST uses an especial installation-helper binary to configure snapper and create snapshots during installation and offline upgrade. However, it does not work with LVM (at least not in all cases). This PR changes the FsSnapshot class to use the snapper binary (using the --no-dbus option) to create snapshots. The configuration phase is still done through installation-helper.

Additionally, it introduces a new kind of exception so errors when creating snapshots can be properly handled.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.02%) to 28.363% when pulling f2f32a3168b5384443e845d0896b6884c1e0fa38 on bsc-1180142 into 1d9902dff0bf5518b8f05b0fcd44140837db4689 on SLE-15-SP1.