yast / yast-yast2

YaST module yast2
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
56 stars 44 forks source link

Do not propose hibernation on virtual setups #1134

Closed joseivanlopez closed 3 years ago

joseivanlopez commented 3 years ago

Problem

The method Kernel#propose_hibernation? was returning true when the system is running over certain virtualized setups like hyper-v. This makes to yast2-bootloader to propose the resume= kernel parameter in such scenarios, , but it should not do it according to https://jira.suse.com/browse/SLE-12280.

Solution

Now Kernel#propose_hibernation? uses the new method Arch#is_virtual? to check whether the system is running on a virtualized setup, does not matter the specific virtualization technology. For now this is enough, but maybe in the future we might need a more fine grained detection. In that case, we could consider to use virt-what utility. For example, to check what is the specific virtualization technology in use (kvm, hyper-v, etc).

yast-bot commented 3 years ago

:heavy_check_mark: Public Jenkins job #279 successfully finished :heavy_check_mark: Created OBS submit request #867182

yast-bot commented 3 years ago

:heavy_check_mark: Internal Jenkins job #141 successfully finished :heavy_check_mark: Created IBS submit request #234541