search

yast / yast-yast2

YaST module yast2
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
55 stars 44 forks source link

[SLE-15-SP3] Do not convert result to sym directly #1161

Closed dgdavid closed 3 years ago

dgdavid commented 3 years ago

Problem

A call to Convert.to_symbol was wrongly changed in https://github.com/yast/yast-yast2/pull/1143, which makes the installation crash with a NoMethodError (undefined method ``to_sym' for false:FalseClass) when the result from a client is false

Solution

A kind of revert to previous code and keep using result = Convert.to_symbol(result) instead result = result.to_sym

Additional note

The Bugzilla reference for version 4.3.59 has been fixed, switching from bsc#1180594 to bsc#1180954

SR: https://build.suse.de/request/show/240650

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.04%) to 40.543% when pulling 06275820a9a5db98200ec2df473419fde65c51ae on bsc-1185561 into fe7ea8ccf4c20b2a6f20e0da331f9b161446ea37 on SLE-15-SP3.

wfeldt commented 3 years ago

Although I still don't know what exactly triggers the bug...

dgdavid commented 3 years ago

Although I still don't know what exactly triggers the bug...

I see. We can wait to know more before merging it, just in case we could include more changes.

wfeldt commented 3 years ago

The provided logs show that this was triggered by a failing install step (https://bugzilla.suse.com/show_bug.cgi?id=1185545, seemingly) that wasn't mentioned in the bug.