search

yast / yast-yast2

YaST module yast2
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
54 stars 44 forks source link

Add Equatable mixin #1165

Closed joseivanlopez closed 3 years ago

joseivanlopez commented 3 years ago

Problem

Objects redefining #eql? method should redefine #hash method too. These two methods must be paired, otherwise some actions like subtracting arrays could generate unexpected results.

Solution

Add a Equatable mixin for keep #eql? and #hash paired.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.03%) to 40.923% when pulling 8f57a3e4cb1ad1a935596fd56d50af3cb43d0231 on joseivanlopez:equatable into e9b29cf6ac80a2ef9148021c516f4e58e09d9123 on yast:master.

teclator commented 3 years ago

LGTM

yast-bot commented 3 years ago

:heavy_check_mark: Public Jenkins job #306 successfully finished :heavy_check_mark: Created OBS submit request #895495