Closed ancorgs closed 3 years ago
:heavy_check_mark: Public Jenkins job #315 successfully finished :heavy_check_mark: Created OBS submit request #902299
:heavy_check_mark: Internal Jenkins job #153 successfully finished :heavy_check_mark: Created IBS submit request #243830
Related pull requests
Problem
During the partial re-implementation of yast2-users, we found a couple of things to be improved in Y2Issues.
1) The Y2Issues severity levels were
:warn
and:fatal
. But other parts of YaST use slightly different conventions for similar concepts[1]:Report
there are functions line,Message
,Warning
andError
.<report>
section of the AutoYaST profile, it's possible to define the behavior for the following categories: errors, warnings, messages, yesno_messages.2) The current implementation of
Y2Issues.report
was too focused in a single use case - showing errors found while processing the AutoYaST profile and offering the user the opportunity to abort installation.Solution
:fatal
to:error
.Y2Issue.report
with two new arguments that allow to specify what to do depending on the severity of the issues.Testing
Notes
[1] The installation proposals follow a different convention, but I don't think it's expected to use Y2Issues in that context. Just for completeness, let's list here the warning levels accepted for a proposal:
:notice
:warning
(default):error
:blocker
:fatal
A
:blocker
will prevent the user from continuing the installation. If any proposal contains a blocker warning, the Accept button in the proposal dialog will be disabled - the user needs to fix that blocker before continuing.:fatal
is like:blocker
but also stops building the proposal.An
:error
does not prevent continuing of the installation, but shows a popup that an user has to confirm to continue with the installation.