Fixed losing the product selection (bsc#1190228)

lslezak commented 2 years ago

The Problem

https://bugzilla.suse.com/show_bug.cgi?id=1190228
The products from addon modules are not selected to install, see the screenshot

sp4_addons_not_selected

Details

It turned out that the products actually are selected after adding the repositories
But the selection is lost when reaching the installation summary
Further debugging revealed the the selection is lost after calling Pkg.SourceStartCache which (re)loads the repositories
That's actually not needed during installation, that code is mainly intended for installed system
In the past this was OK, maybe some libzypp behavior has been changed...

The Fix

The code which loads the repositories was fixed to avoid reloads when at least one repository is defined
- During installation, where at least one repository is present, it will skip the repository load
- In installed system it will load the repositories unless they are already loaded

Testing

Tested manually in the latest SP4 build, all products are correctly selected to install

sp4_addons_selected

coveralls commented 2 years ago

Coverage increased (+0.0008%) to 41.218% when pulling 428aa3e0d218cec6984469cd7dcb52f93f4bb751 on product_selection into 2e561accfefa6025957ed38229bf430ab773904d on master.

yast-bot commented 2 years ago

:heavy_check_mark: Public Jenkins job #326 successfully finished :heavy_check_mark: Created OBS submit request #919733

yast-bot commented 2 years ago

:heavy_check_mark: Internal Jenkins job #164 successfully finished :heavy_check_mark: Created IBS submit request #252256

yast / yast-yast2