Popup.YesNo(): Unify the internal [No] button ID (bsc#1193326)

yast / yast-yast2

YaST module yast2

http://en.opensuse.org/Portal:YaST

GNU General Public License v2.0

54 stars 44 forks source link

Popup.YesNo(): Unify the internal [No] button ID (bsc#1193326) #1208

Closed lslezak closed 2 years ago

lslezak commented 2 years ago

Unify the internal button IDs
The new [Yast2::Popup]() class use the :yes and :no IDs while the old Popup module uses the :yes and :no_button IDs
That's inconsistent and makes testing via libyui REST API more difficult as you need to know which implementation is used to display a particular popup
So let's use the same IDs everywhere :+1:
Additionally the code has been refactored and simplified

coveralls commented 2 years ago

Coverage increased (+0.07%) to 41.148% when pulling e00d55d12b720fd2205ce98c0eb4613201d0525a on no_button into 5ff8848301246d5aa7c0ba167f1dc7cda3cffae9 on master.

yast-bot commented 2 years ago

:heavy_check_mark: Public Jenkins job #334 successfully finished :heavy_check_mark: Created OBS submit request #935230