Fixed RelURL unit test randomly crashing

yast / yast-yast2

YaST module yast2

http://en.opensuse.org/Portal:YaST

GNU General Public License v2.0

54 stars 44 forks source link

Fixed RelURL unit test randomly crashing #1218

Closed lslezak closed 2 years ago

lslezak commented 2 years ago

Fixes a Jenkins crash ("component cannot import namespace 'InstURL'").
The problem was that the Yast::InstURL module is part of the yast2-packager package, but we cannot build depend on it to avoid circular dependecies.
That module is mocked at some else unit tests so it depended on the order of executing the tests, if the RelURL test was executed too early the Yast::InstURL module was not mocked yet and it crashed.
Fixed by moving the mock to the top level test helper.

coveralls commented 2 years ago

Coverage remained the same at 41.455% when pulling a14ad13427fe824714f1b642c477f137b692175b on relurl_test_fix into a544805651c18002c5b5a9133c9078259fef95fe on master.

yast-bot commented 2 years ago

:heavy_check_mark: Public Jenkins job #337 successfully finished :heavy_check_mark: Created OBS submit request #940743

yast-bot commented 2 years ago

:heavy_check_mark: Internal Jenkins job #174 successfully finished :heavy_check_mark: Created IBS submit request #260465