search

yast / yast-yast2

YaST module yast2
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
54 stars 44 forks source link

Add Y2Packager::Resolvable.none? method #1227

Closed teclator closed 2 years ago

teclator commented 2 years ago

Problem

We recently have updated rubocop to 0.71.0 version in yast2-installation renaming the Y2Packager::Resolvable.any? call to Y2Packager::Resolvable.none? automatically, but the .none? method is not implemented

Solution

Added Y2Packager::Resolvable.none? method in order to fix the crash but also prevent future rubocop auto change issue.

https://github.com/yast/yast-installation/pull/1009/files#diff-9e5517485ccbd905e33ffea54a28ce8474b226e3faea35dc1893f28ee769b70aR244

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-0.02%) to 41.429% when pulling a7d86bc672d3c6e252e54236f5a14318b3ceba09 on add_none_method into 8c6f0fe1d8b82da1c76d227defa2cd447818e5fd on master.

yast-bot commented 2 years ago

:heavy_check_mark: Public Jenkins job #341 successfully finished :heavy_check_mark: Created OBS submit request #944685

yast-bot commented 2 years ago

:x: Internal Jenkins job #179 failed