Adapt Report.yesno_popup to Ruby 3 (bsc#1193192)

yast / yast-yast2

YaST module yast2

http://en.opensuse.org/Portal:YaST

GNU General Public License v2.0

54 stars 44 forks source link

Adapt Report.yesno_popup to Ruby 3 (bsc#1193192) #1233

Closed ancorgs closed 2 years ago

ancorgs commented 2 years ago

A hash was being passed to a method expecting the hash would be interpreted as a set of keyword params. That works in Ruby 2 as-is, but in Ruby 3 the ** operator must be used.

The problem was detected by me when trying to open two instances of the Partitioner and also by the internal SUSE openQA instance during this test: https://openqa.suse.de/tests/overview?distri=sle&version=15-SP4&build=Y.52.5&groupid=125

coveralls commented 2 years ago

Coverage remained the same at 41.286% when pulling a008ea79e23805b5a40c0c0e80cd924f74c3d1e9 on ancorgs:yesno_ruby3 into 66d5a1818fad2a655788da7a41662602e0a13b3a on yast:master.

yast-bot commented 2 years ago

:heavy_check_mark: Internal Jenkins job #186 successfully finished :heavy_check_mark: Created IBS submit request #262245

yast-bot commented 2 years ago

:heavy_check_mark: Public Jenkins job #349 successfully finished :heavy_check_mark: Created OBS submit request #946436