search

yast / yast-yast2

YaST module yast2
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
54 stars 44 forks source link

Do not crash when checking file conflicts and delayed progress popup is not shown #1264

Closed dgdavid closed 1 year ago

dgdavid commented 1 year ago

Problem

YaST crash when checking file conflicts because of a Yast::UI.PollInput call when there is no UI (the requirements for displaying the Yast::DelayedProgressPopup were not fulfilled)

nodialog

Solution

Fix the Yast::FileConflictCallbacks#progress method for polling user input only if the delayed progress popup dialog is open.

Testing

Related to https://github.com/yast/yast-yast2/pull/1252

coveralls commented 1 year ago

Coverage Status

Coverage increased (+0.01%) to 41.643% when pulling 3f8399b8aaeb67904e2f3d077cb73b4c8d3be209 on bsc-1201924 into c43b61f0fbb7c9a981f66de3b1c547e191552527 on master.

yast-bot commented 1 year ago

:heavy_check_mark: Public Jenkins job #376 successfully finished :heavy_check_mark: Created OBS submit request #991529

yast-bot commented 1 year ago

:x: Internal Jenkins job #199 failed

yast-bot commented 1 year ago

:heavy_check_mark: Internal Jenkins job #200 successfully finished :heavy_check_mark: Created IBS submit request #276634