Container-compatible check for the journal client

ancorgs commented 2 years ago

Problem

When trying to open certain deprecated log files, the view_anymsg client may suggest to install yast2-journal. It basically does the following:

It asks the user whether journal should be called instead.
In case journal is not installed, it installs it (if possible).
Open journal unless is not there and installation failed.

That mechanism is quite broken when view_anymsg is containerized. The root of the problem is that view_anymsg relies on Package.Install("yast2-journal") without previously checking whether the client is already there. Since YaST's package manager checks for packages in the host system, it concludes yast2-journal is not available and the whole process fails even if the journal client is actually part of the same container.

Solution

Check for the existence of the journal client before resorting to Package.Install. If that client is included in the container (which is always the case in the official YaST containers), then everything will work. If the client is there then there is no need to check for the package.

NOTE: if the container does not contain the journal client then this pull request fixes nothing and the current (broken) behavior remains. But that's a theoretical problem because all the official YaST containers include yast2-journal.

Testing

Extended unit tests
Manually tested in a non containerized YaST (nothing has changed).
Manually tested with a containerized YaST on top of ALP (it fixes the problem, the journal client opens correctly).

coveralls commented 2 years ago

Coverage increased (+0.004%) to 41.684% when pulling 3d6d074d58929ea7bf9b4beaf2c347d3d7d02937 on ancorgs:container_journal into b63ec1fd8893a9c01d5dee2e5e2ce7fab242da78 on yast:master.

yast-bot commented 2 years ago

:heavy_check_mark: Public Jenkins job #385 successfully finished :heavy_check_mark: Created OBS submit request #1006698

yast-bot commented 2 years ago

:heavy_check_mark: Internal Jenkins job #209 successfully finished :heavy_check_mark: Created IBS submit request #281062

yast / yast-yast2