Fix hash vs keyword arguments in RSpec expectations (bsc#1204871)

mvidner commented 1 year ago

Problem

https://bugzilla.opensuse.org/show_bug.cgi?id=1204871 "- [Staging] rubygem-rspec-* 3.12 breaks various yast modules build"
this description is copied from https://github.com/yast/yast-registration/pull/584 as this is a base library. Further PRs will just link here

New rspec-mocks distinguish between hash and keyword arguments passed to with.

The tested code does use hashes but we've used keywords in tests because it's shorter to write. Fixed.

rspec-mocks 3.11.2 / 2022-10-25:

Bug Fixes: Support keyword argument semantics when constraining argument expectations using with on Ruby 3.0+ with instance_double https://github.com/rspec/rspec-mocks/pull/1473

Solution

Use hashes in tests instead of keywords

Testing

[x] Red-green tested with manually installed rspec 3.12.0

Screenshots

Not affected

yast-bot commented 1 year ago

:heavy_check_mark: Public Jenkins job #392 successfully finished :heavy_check_mark: Created OBS submit request #1033485

yast-bot commented 1 year ago

:heavy_check_mark: Internal Jenkins job #215 successfully finished :heavy_check_mark: Created IBS submit request #283695

yast / yast-yast2