Fix help button in YaST Control Center

[joseivanlopez]

Problem

With ncurses UI, the YaST Control Center shows a help button which opens an empty popup (help texts provided by the client are missing).

Note: this problem only affects to the ncurses UI because the help button is not offered in the Qt UI.

• https://bugzilla.suse.com/show_bug.cgi?id=1206919

Solution

The help button's option :helpButton was used in a wrong way: if it is used, the click/activate event of that button is handled purely internal in libyui. In that case, libyui traverses up the widget hierarchy to find the next widget that has a property :helpText set and uses that text for a (UI internal) help window's content.

In this case, the button has that option, but the application wants to handle the event itself (there is no widget with:helpText property in the hierarchy).

Removing the :helpButton option on the help button fixes the problem.

Testing

• Tested manually

Screenshots

[coveralls]

Coverage: 41.727% (-0.05%) from 41.778% when pulling cbd97c51477c4b8751a7dccd3580e064aa35ee4a on joseivanlopez:control-center-help into 5597098d55bb9143cf3db4dd43f01ff689f68700 on yast:master.

[yast-bot]

:heavy_check_mark: Public Jenkins job #394 successfully finished :heavy_check_mark: Created OBS submit request #1057610

[yast-bot]

:heavy_check_mark: Internal Jenkins job #217 successfully finished :heavy_check_mark: Created IBS submit request #287917